lkml.org 
[lkml]   [2022]   [Aug]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 498/779] um: random: Dont initialise hwrng struct with zero
    Date
    From: Christopher Obbard <chris.obbard@collabora.com>

    [ Upstream commit 9e70cbd11b03889c92462cf52edb2bd023c798fa ]

    Initialising the hwrng struct with zeros causes a
    compile-time sparse warning:

    $ ARCH=um make -j10 W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
    ...
    CHECK arch/um/drivers/random.c
    arch/um/drivers/random.c:31:31: sparse: warning: Using plain integer as NULL pointer

    Fix the warning by not initialising the hwrng struct
    with zeros as it is initialised anyway during module
    init.

    Fixes: 72d3e093afae ("um: random: Register random as hwrng-core device")
    Reported-by: kernel test robot <lkp@intel.com>
    Signed-off-by: Christopher Obbard <chris.obbard@collabora.com>
    Signed-off-by: Richard Weinberger <richard@nod.at>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    arch/um/drivers/random.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/arch/um/drivers/random.c b/arch/um/drivers/random.c
    index 433a3f8f2ef3..32b3341fe970 100644
    --- a/arch/um/drivers/random.c
    +++ b/arch/um/drivers/random.c
    @@ -28,7 +28,7 @@
    * protects against a module being loaded twice at the same time.
    */
    static int random_fd = -1;
    -static struct hwrng hwrng = { 0, };
    +static struct hwrng hwrng;
    static DECLARE_COMPLETION(have_data);

    static int rng_dev_read(struct hwrng *rng, void *buf, size_t max, bool block)
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-08-15 21:23    [W:3.323 / U:0.176 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site