lkml.org 
[lkml]   [2022]   [Aug]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 433/779] mwifiex: Ignore BTCOEX events from the 88W8897 firmware
    Date
    From: Jonas Dreßler <verdre@v0yd.nl>

    [ Upstream commit 84d94e16efa268e4f2887d858cd67ee37b870f25 ]

    The firmware of the 88W8897 PCIe+USB card sends those events very
    unreliably, sometimes bluetooth together with 2.4ghz-wifi is used and no
    COEX event comes in, and sometimes bluetooth is disabled but the
    coexistance mode doesn't get disabled.

    This means we sometimes end up capping the rx/tx window size while
    bluetooth is not enabled anymore, artifically limiting wifi speeds even
    though bluetooth is not being used.

    Since we can't fix the firmware, let's just ignore those events on the
    88W8897 device. From some Wireshark capture sessions it seems that the
    Windows driver also doesn't change the rx/tx window sizes when bluetooth
    gets enabled or disabled, so this is fairly consistent with the Windows
    driver.

    Signed-off-by: Jonas Dreßler <verdre@v0yd.nl>
    Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
    Link: https://lore.kernel.org/r/20211103205827.14559-1-verdre@v0yd.nl
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/wireless/marvell/mwifiex/main.h | 2 ++
    drivers/net/wireless/marvell/mwifiex/pcie.c | 3 +++
    drivers/net/wireless/marvell/mwifiex/sta_event.c | 3 +++
    3 files changed, 8 insertions(+)

    diff --git a/drivers/net/wireless/marvell/mwifiex/main.h b/drivers/net/wireless/marvell/mwifiex/main.h
    index 5923c5c14c8d..f4e3dce10d65 100644
    --- a/drivers/net/wireless/marvell/mwifiex/main.h
    +++ b/drivers/net/wireless/marvell/mwifiex/main.h
    @@ -1054,6 +1054,8 @@ struct mwifiex_adapter {
    void *devdump_data;
    int devdump_len;
    struct timer_list devdump_timer;
    +
    + bool ignore_btcoex_events;
    };

    void mwifiex_process_tx_queue(struct mwifiex_adapter *adapter);
    diff --git a/drivers/net/wireless/marvell/mwifiex/pcie.c b/drivers/net/wireless/marvell/mwifiex/pcie.c
    index c3f5583ea70d..d5fb29400bad 100644
    --- a/drivers/net/wireless/marvell/mwifiex/pcie.c
    +++ b/drivers/net/wireless/marvell/mwifiex/pcie.c
    @@ -3152,6 +3152,9 @@ static int mwifiex_init_pcie(struct mwifiex_adapter *adapter)
    if (ret)
    goto err_alloc_buffers;

    + if (pdev->device == PCIE_DEVICE_ID_MARVELL_88W8897)
    + adapter->ignore_btcoex_events = true;
    +
    return 0;

    err_alloc_buffers:
    diff --git a/drivers/net/wireless/marvell/mwifiex/sta_event.c b/drivers/net/wireless/marvell/mwifiex/sta_event.c
    index 2b2e6e0166e1..7d42c5d2dbf6 100644
    --- a/drivers/net/wireless/marvell/mwifiex/sta_event.c
    +++ b/drivers/net/wireless/marvell/mwifiex/sta_event.c
    @@ -1062,6 +1062,9 @@ int mwifiex_process_sta_event(struct mwifiex_private *priv)
    break;
    case EVENT_BT_COEX_WLAN_PARA_CHANGE:
    dev_dbg(adapter->dev, "EVENT: BT coex wlan param update\n");
    + if (adapter->ignore_btcoex_events)
    + break;
    +
    mwifiex_bt_coex_wlan_param_update_event(priv,
    adapter->event_skb);
    break;
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-08-15 21:11    [W:4.033 / U:0.176 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site