lkml.org 
[lkml]   [2022]   [Aug]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 420/779] scsi: qla2xxx: edif: Reduce disruption due to multiple app start
    Date
    From: Quinn Tran <qutran@marvell.com>

    [ Upstream commit 0dbfce5255fe8d069a1a3b712a25b263264cfa58 ]

    Multiple app start can trigger a session bounce. Make driver skip over
    session teardown if app start is seen more than once.

    Link: https://lore.kernel.org/r/20220608115849.16693-4-njavali@marvell.com
    Fixes: 7ebb336e45ef ("scsi: qla2xxx: edif: Add start + stop bsgs")
    Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
    Signed-off-by: Quinn Tran <qutran@marvell.com>
    Signed-off-by: Nilesh Javali <njavali@marvell.com>
    Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/scsi/qla2xxx/qla_edif.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/scsi/qla2xxx/qla_edif.c b/drivers/scsi/qla2xxx/qla_edif.c
    index 69f8d16effa6..f7953ce17678 100644
    --- a/drivers/scsi/qla2xxx/qla_edif.c
    +++ b/drivers/scsi/qla2xxx/qla_edif.c
    @@ -486,8 +486,7 @@ qla_edif_app_start(scsi_qla_host_t *vha, struct bsg_job *bsg_job)
    /* mark doorbell as active since an app is now present */
    vha->e_dbell.db_flags |= EDB_ACTIVE;
    } else {
    - ql_dbg(ql_dbg_edif, vha, 0x911e, "%s doorbell already active\n",
    - __func__);
    + goto out;
    }

    if (N2N_TOPO(vha->hw)) {
    @@ -555,6 +554,7 @@ qla_edif_app_start(scsi_qla_host_t *vha, struct bsg_job *bsg_job)
    __func__);
    }

    +out:
    appreply.host_support_edif = vha->hw->flags.edif_enabled;
    appreply.edif_enode_active = vha->pur_cinfo.enode_flags;
    appreply.edif_edb_active = vha->e_dbell.db_flags;
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-08-15 21:10    [W:5.876 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site