lkml.org 
[lkml]   [2022]   [Aug]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 410/779] mtd: parsers: ofpart: Fix refcount leak in bcm4908_partitions_fw_offset
    Date
    From: Miaoqian Lin <linmq006@gmail.com>

    [ Upstream commit e607879b0da18c451de5e91daf239cc2f2f8ff2d ]

    of_find_node_by_path() returns a node pointer with refcount incremented,
    we should use of_node_put() on it when not need anymore.
    Add missing of_node_put() to avoid refcount leak.

    Fixes: bb17230c61a6 ("mtd: parsers: ofpart: support BCM4908 fixed partitions")
    Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
    Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
    Link: https://lore.kernel.org/linux-mtd/20220605070726.5979-1-linmq006@gmail.com
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/mtd/parsers/ofpart_bcm4908.c | 3 +++
    1 file changed, 3 insertions(+)

    diff --git a/drivers/mtd/parsers/ofpart_bcm4908.c b/drivers/mtd/parsers/ofpart_bcm4908.c
    index 0eddef4c198e..bb072a0940e4 100644
    --- a/drivers/mtd/parsers/ofpart_bcm4908.c
    +++ b/drivers/mtd/parsers/ofpart_bcm4908.c
    @@ -35,12 +35,15 @@ static long long bcm4908_partitions_fw_offset(void)
    err = kstrtoul(s + len + 1, 0, &offset);
    if (err) {
    pr_err("failed to parse %s\n", s + len + 1);
    + of_node_put(root);
    return err;
    }

    + of_node_put(root);
    return offset << 10;
    }

    + of_node_put(root);
    return -ENOENT;
    }

    --
    2.35.1


    \
     
     \ /
      Last update: 2022-08-15 21:09    [W:3.903 / U:0.700 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site