lkml.org 
[lkml]   [2022]   [Aug]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 409/779] mtd: partitions: Fix refcount leak in parse_redboot_of
    Date
    From: Miaoqian Lin <linmq006@gmail.com>

    [ Upstream commit 9f7e62815cf3cbbcb1b8cb21649fb4dfdb3aa016 ]

    of_get_child_by_name() returns a node pointer with refcount
    incremented, we should use of_node_put() on it when not need anymore.
    Add missing of_node_put() to avoid refcount leak.

    Fixes: 237960880960 ("mtd: partitions: redboot: seek fis-index-block in the right node")
    Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
    Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
    Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
    Link: https://lore.kernel.org/linux-mtd/20220526110652.64849-1-linmq006@gmail.com
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/mtd/parsers/redboot.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/mtd/parsers/redboot.c b/drivers/mtd/parsers/redboot.c
    index feb44a573d44..a16b42a88581 100644
    --- a/drivers/mtd/parsers/redboot.c
    +++ b/drivers/mtd/parsers/redboot.c
    @@ -58,6 +58,7 @@ static void parse_redboot_of(struct mtd_info *master)
    return;

    ret = of_property_read_u32(npart, "fis-index-block", &dirblock);
    + of_node_put(npart);
    if (ret)
    return;

    --
    2.35.1


    \
     
     \ /
      Last update: 2022-08-15 21:09    [W:2.237 / U:0.072 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site