lkml.org 
[lkml]   [2022]   [Aug]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 326/779] mt76: mt76x02u: fix possible memory leak in __mt76x02u_mcu_send_msg
    Date
    From: Lorenzo Bianconi <lorenzo@kernel.org>

    [ Upstream commit cffd93411575afd987788e2ec3cb8eaff70f0215 ]

    Free the skb if mt76u_bulk_msg fails in __mt76x02u_mcu_send_msg routine.

    Fixes: 4c89ff2c74e39 ("mt76: split __mt76u_mcu_send_msg and mt76u_mcu_send_msg routines")
    Co-developed-by: Gergo Koteles <soyer@irl.hu>
    Signed-off-by: Gergo Koteles <soyer@irl.hu>
    Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
    Signed-off-by: Felix Fietkau <nbd@nbd.name>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/wireless/mediatek/mt76/mt76x02_usb_mcu.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/net/wireless/mediatek/mt76/mt76x02_usb_mcu.c b/drivers/net/wireless/mediatek/mt76/mt76x02_usb_mcu.c
    index 2953df7d8388..c6c16fe8ee85 100644
    --- a/drivers/net/wireless/mediatek/mt76/mt76x02_usb_mcu.c
    +++ b/drivers/net/wireless/mediatek/mt76/mt76x02_usb_mcu.c
    @@ -108,7 +108,7 @@ __mt76x02u_mcu_send_msg(struct mt76_dev *dev, struct sk_buff *skb,
    ret = mt76u_bulk_msg(dev, skb->data, skb->len, NULL, 500,
    MT_EP_OUT_INBAND_CMD);
    if (ret)
    - return ret;
    + goto out;

    if (wait_resp)
    ret = mt76x02u_mcu_wait_resp(dev, seq);
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-08-15 21:01    [W:6.149 / U:0.044 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site