lkml.org 
[lkml]   [2022]   [Aug]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 180/779] ARM: OMAP2+: Fix refcount leak in omapdss_init_of
    Date
    From: Miaoqian Lin <linmq006@gmail.com>

    [ Upstream commit 9705db1eff38d6b9114121f9e253746199b759c9 ]

    omapdss_find_dss_of_node() calls of_find_compatible_node() to get device
    node. of_find_compatible_node() returns a node pointer with refcount
    incremented, we should use of_node_put() on it when done.
    Add missing of_node_put() in later error path and normal path.

    Fixes: e0c827aca0730 ("drm/omap: Populate DSS children in omapdss driver")
    Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
    Message-Id: <20220601044858.3352-1-linmq006@gmail.com>
    Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
    Signed-off-by: Tony Lindgren <tony@atomide.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    arch/arm/mach-omap2/display.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/arch/arm/mach-omap2/display.c b/arch/arm/mach-omap2/display.c
    index eb09a25e3b45..8d829f3dafe7 100644
    --- a/arch/arm/mach-omap2/display.c
    +++ b/arch/arm/mach-omap2/display.c
    @@ -260,11 +260,13 @@ static int __init omapdss_init_of(void)

    if (!pdev) {
    pr_err("Unable to find DSS platform device\n");
    + of_node_put(node);
    return -ENODEV;
    }

    r = of_platform_populate(node, NULL, NULL, &pdev->dev);
    put_device(&pdev->dev);
    + of_node_put(node);
    if (r) {
    pr_err("Unable to populate DSS submodule devices\n");
    return r;
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-08-15 20:37    [W:2.237 / U:0.392 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site