lkml.org 
[lkml]   [2022]   [Aug]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 165/779] soc: amlogic: Fix refcount leak in meson-secure-pwrc.c
    Date
    From: Liang He <windhl@126.com>

    [ Upstream commit d18529a4c12f66d83daac78045ea54063bd43257 ]

    In meson_secure_pwrc_probe(), there is a refcount leak in one fail
    path.

    Signed-off-by: Liang He <windhl@126.com>
    Acked-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
    Fixes: b3dde5013e13 ("soc: amlogic: Add support for Secure power domains controller")
    Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
    Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
    Link: https://lore.kernel.org/r/20220616144915.3988071-1-windhl@126.com
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/soc/amlogic/meson-secure-pwrc.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    diff --git a/drivers/soc/amlogic/meson-secure-pwrc.c b/drivers/soc/amlogic/meson-secure-pwrc.c
    index 59bd195fa9c9..2eeea5e1b3b7 100644
    --- a/drivers/soc/amlogic/meson-secure-pwrc.c
    +++ b/drivers/soc/amlogic/meson-secure-pwrc.c
    @@ -139,8 +139,10 @@ static int meson_secure_pwrc_probe(struct platform_device *pdev)
    }

    pwrc = devm_kzalloc(&pdev->dev, sizeof(*pwrc), GFP_KERNEL);
    - if (!pwrc)
    + if (!pwrc) {
    + of_node_put(sm_np);
    return -ENOMEM;
    + }

    pwrc->fw = meson_sm_get(sm_np);
    of_node_put(sm_np);
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-08-15 20:33    [W:2.866 / U:0.132 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site