Messages in this thread | | | From | "Wang, Haiyue" <> | Subject | RE: [PATCH v3 2/2] mm: fix the handling Non-LRU pages returned by follow_page | Date | Mon, 15 Aug 2022 01:46:59 +0000 |
| |
> -----Original Message----- > From: Huang, Ying <ying.huang@intel.com> > Sent: Monday, August 15, 2022 09:40 > To: Wang, Haiyue <haiyue.wang@intel.com> > Cc: linux-mm@kvack.org; linux-kernel@vger.kernel.org; akpm@linux-foundation.org; david@redhat.com; > linmiaohe@huawei.com; songmuchun@bytedance.com; naoya.horiguchi@linux.dev; alex.sierra@amd.com; Felix > Kuehling <Felix.Kuehling@amd.com>; Alistair Popple <apopple@nvidia.com> > Subject: Re: [PATCH v3 2/2] mm: fix the handling Non-LRU pages returned by follow_page > > Haiyue Wang <haiyue.wang@intel.com> writes: > > > The page returned by follow_page with 'FOLL_GET' has get_page called, so > > Better to add "()" after function name to improve the readability, for > example, "follow_page()".
Got it, didn't notice this. ;-)
> > > it needs to call put_page for handling the reference count correctly. > > > > And as David reviewed, "device pages are never PageKsm pages". Drop this > > zone device page check for break_ksm. > > > > Fixes: 3218f8712d6b ("mm: handling Non-LRU pages returned by vm_normal_pages") > > In your patch description, I cannot find how the above commit is related > to the bug you fixed. Add some words about that?
The first commit session, but maybe not very clear, will try to add more words In v4.
> > Best Regards, > Huang, Ying > > > Signed-off-by: Haiyue Wang <haiyue.wang@intel.com> > > --- > > mm/huge_memory.c | 4 ++-- > > mm/ksm.c | 12 +++++++++--- > > mm/migrate.c | 10 +++++++--- > > 3 files changed, 18 insertions(+), 8 deletions(-) > >
| |