Messages in this thread | | | From | Justin He <> | Subject | RE: [PATCH 1/2] efi/cper: export several helpers for ghes edac to use | Date | Mon, 15 Aug 2022 01:13:35 +0000 |
| |
Hi Boris
> -----Original Message----- > From: Borislav Petkov <bp@alien8.de> > Sent: Friday, August 12, 2022 10:46 PM > To: Justin He <Justin.He@arm.com> > Cc: Ard Biesheuvel <ardb@kernel.org>; Len Brown <lenb@kernel.org>; James > Morse <James.Morse@arm.com>; Tony Luck <tony.luck@intel.com>; Mauro > Carvalho Chehab <mchehab@kernel.org>; Robert Richter <rric@kernel.org>; > Robert Moore <robert.moore@intel.com>; linux-acpi@vger.kernel.org; > linux-kernel@vger.kernel.org; linux-edac@vger.kernel.org; devel@acpica.org; > Rafael J . Wysocki <rafael@kernel.org>; Shuai Xue > <xueshuai@linux.alibaba.com>; Jarkko Sakkinen <jarkko@kernel.org>; > linux-efi@vger.kernel.org; nd <nd@arm.com>; toshi.kani@hpe.com > Subject: Re: [PATCH 1/2] efi/cper: export several helpers for ghes edac to use > > On Thu, Aug 11, 2022 at 09:17:12AM +0000, Jia He wrote: > > Before modularizing the ghes_edac codes, we need to export several > > efi/cper > > Who's we? > > Please use passive voice in your commit message: no "we" or "I", etc, and > describe your changes in imperative mood. > > Also, pls read section "2) Describe your changes" in > Documentation/process/submitting-patches.rst for more details. > > Also, see section "Changelog" in > Documentation/process/maintainer-tip.rst > > Bottom line is: personal pronouns are ambiguous in text, especially with so > many parties/companies/etc developing the kernel so let's avoid them please. Okay,I will fix the commit description in next version.
-- Cheers, Justin (Jia He)
| |