Messages in this thread | | | From | "Wang, Haiyue" <> | Subject | RE: [PATCH v2 1/3] mm: revert handling Non-LRU pages returned by follow_page | Date | Mon, 15 Aug 2022 01:02:32 +0000 |
| |
> -----Original Message----- > From: David Hildenbrand <david@redhat.com> > Sent: Monday, August 15, 2022 00:31 > To: Wang, Haiyue <haiyue.wang@intel.com>; linux-mm@kvack.org; linux-kernel@vger.kernel.org > Cc: akpm@linux-foundation.org; linmiaohe@huawei.com; Huang, Ying <ying.huang@intel.com>; > songmuchun@bytedance.com; naoya.horiguchi@linux.dev; alex.sierra@amd.com > Subject: Re: [PATCH v2 1/3] mm: revert handling Non-LRU pages returned by follow_page > > On 14.08.22 16:05, Haiyue Wang wrote: > > The commit > > 3218f8712d6b ("mm: handling Non-LRU pages returned by vm_normal_pages") > > doesn't handle the follow_page with flag FOLL_GET correctly, this will > > do get_page on page, it shouldn't just return directly without put_page. > > > > So revert the related fix to prepare for clean patch to handle Non-LRU > > pages returned by follow_page. > > What? Why? >
Just as the cover letter said, for applying the PATCH 2/3 can be applied on Linux-5.19 branch directly. I will drop this kind of fix, and fix the issue directly in v3.
> Just fix it. > > -- > Thanks, > > David / dhildenb
| |