lkml.org 
[lkml]   [2022]   [Aug]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] media: rockchip: rga: Fix probe rga_parse_dt bugs
From

On 8/14/22 23:12, Peter Geis wrote:
>> ret = rga_parse_dt(rga);
>> - if (ret)
>> + if (ret) {
>> dev_err(&pdev->dev, "Unable to parse OF data\n");
> If this can return EPROBE_DEFER, shouldn't this be dev_err_probe
> instead of dev_err?


Looking into it that does make more sense. I suspect it wasn't done this
way originally because dev_err_probe isn't used elsewhere in rga.c. I'll
send a v2 with that change shortly.


Thanks for the review.

\
 
 \ /
  Last update: 2022-08-15 00:02    [W:0.058 / U:0.096 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site