Messages in this thread | | | From | Emeel Hakim <> | Subject | RE: [PATCH net 1/1] net: macsec: Fix XPN properties passing to macsec offload | Date | Sun, 14 Aug 2022 07:32:05 +0000 |
| |
> -----Original Message----- > From: Jakub Kicinski <kuba@kernel.org> > Sent: Thursday, 11 August 2022 19:26 > To: Emeel Hakim <ehakim@nvidia.com> > Cc: edumazet@google.com; mayflowerera@gmail.com; pabeni@redhat.com; > netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Raed Salem > <raeds@nvidia.com> > Subject: Re: [PATCH net 1/1] net: macsec: Fix XPN properties passing to macsec > offload > > External email: Use caution opening links or attachments > > > On Tue, 9 Aug 2022 13:29:05 +0300 Emeel Hakim wrote: > > Currently macsec invokes HW offload path before reading extended > > packet number (XPN) related user properties i.e. salt and short secure > > channel identifier (ssci), hence preventing macsec XPN HW offload. > > > > Fix by moving macsec XPN properties reading prior to HW offload path. > > > > Fixes: 48ef50fa866a ("macsec: Netlink support of XPN cipher suites") > > Reviewed-by: Raed Salem <raeds@nvidia.com> > > Signed-off-by: Emeel Hakim <ehakim@nvidia.com> > > Is there a driver in the tree which uses those values today? > I can't grep out any rx_sa->key accesses in the drivers at all :S > > If there is none it's not really a fix.
Thanks for the review, agreed will repost it with commit adjustment to net-next as part of a macsec offload series.
| |