lkml.org 
[lkml]   [2022]   [Aug]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.19 52/64] dmaengine: sprd: Cleanup in .remove() after pm_runtime_get_sync() failed
    Date
    From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

    [ Upstream commit 1e42f82cbec7b2cc4873751e7791e6611901c5fc ]

    It's not allowed to quit remove early without cleaning up completely.
    Otherwise this results in resource leaks that probably yield graver
    problems later. Here for example some tasklets might survive the lifetime
    of the sprd-dma device and access sdev which is freed after .remove()
    returns.

    As none of the device freeing requires an active device, just ignore the
    return value of pm_runtime_get_sync().

    Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
    Reviewed-by: Baolin Wang <baolin.wang7@gmail.com>
    Link: https://lore.kernel.org/r/20220721204054.323602-1-u.kleine-koenig@pengutronix.de
    Signed-off-by: Vinod Koul <vkoul@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/dma/sprd-dma.c | 5 +----
    1 file changed, 1 insertion(+), 4 deletions(-)

    diff --git a/drivers/dma/sprd-dma.c b/drivers/dma/sprd-dma.c
    index 2138b80435ab..474d3ba8ec9f 100644
    --- a/drivers/dma/sprd-dma.c
    +++ b/drivers/dma/sprd-dma.c
    @@ -1237,11 +1237,8 @@ static int sprd_dma_remove(struct platform_device *pdev)
    {
    struct sprd_dma_dev *sdev = platform_get_drvdata(pdev);
    struct sprd_dma_chn *c, *cn;
    - int ret;

    - ret = pm_runtime_get_sync(&pdev->dev);
    - if (ret < 0)
    - return ret;
    + pm_runtime_get_sync(&pdev->dev);

    /* explicitly free the irq */
    if (sdev->irq > 0)
    --
    2.35.1
    \
     
     \ /
      Last update: 2022-08-14 17:34    [W:4.194 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site