Messages in this thread | | | Date | Sat, 13 Aug 2022 06:15:23 -0700 | From | Guenter Roeck <> | Subject | Re: [PATCH 5/5] lib/nodemask: inline next_node_in() and node_random() |
| |
On Thu, Jul 28, 2022 at 08:46:40PM -0700, Guenter Roeck wrote: > On Sun, Jul 10, 2022 at 09:47:11PM -0700, Yury Norov wrote: > > The functions are pretty thin wrappers around find_bit engine, and > > keeping them in c-file prevents compiler from small_const_nbits() > > optimization, which must take place for all systems with MAX_NUMNODES > > less than BITS_PER_LONG (default is 16 for me). > > > > Moving them in header file doesn't blow up the kernel size: > > add/remove: 1/2 grow/shrink: 9/5 up/down: 968/-88 (880) > > > > Signed-off-by: Yury Norov <yury.norov@gmail.com> > > This patch results in > > Building powerpc:allmodconfig ... failed > -------------- > Error log: > In file included from include/linux/nodemask.h:97, > from include/linux/sched.h:22, > from include/linux/sched/mm.h:7, > from arch/powerpc/lib/feature-fixups.c:16: > include/linux/random.h: In function 'add_latent_entropy': > include/linux/random.h:25:46: error: 'latent_entropy' undeclared > > and many more similar errors when trying to compile ppc:allmodconfig. >
As a follow-up on this: The problem is still seen and now made it into the mainline kernel.
Guenter
| |