Messages in this thread | | | Date | Fri, 12 Aug 2022 09:25:18 +0200 | Subject | Re: [PATCH v10 13/13] dm: add power-of-2 target for zoned devices with non power-of-2 zone sizes | From | Pankaj Raghav <> |
| |
Hi Damien,
>> |--------------|---|--------------|---| >> 0 3M 4M 7M 8M >> >> The area between target's zone capacity and zone size will be emulated >> in the target. >> The read IOs that fall in the emulated gap area will return 0 filled >> bio and all the other IOs in that area will result in an error. >> If a read IO span across the emulated area boundary, then the IOs are >> split across them. All other IO operations that span across the emulated >> area boundary will result in an error. >> >> The target can be easily created as follows: >> dmsetup create <label> --table '0 <size_sects> po2zone /dev/nvme<id>' >> >> Note that the target does not support partial mapping of the underlying >> device. >> >> Signed-off-by: Pankaj Raghav <p.raghav@samsung.com> >> Suggested-by: Johannes Thumshirn <johannes.thumshirn@wdc.com> >> Suggested-by: Damien Le Moal <damien.lemoal@wdc.com> >> Suggested-by: Hannes Reinecke <hare@suse.de> >> Reviewed-by: Joel Granados <j.granados@samsung.com> > > You changed this patch. So it needs review again. Please do not carry previous > review tags in that case. > The changes were non-functional such as changing multiplication to shifts and rephrasing error messages.
While I agree with your comment not to carry forward review tags if the patch has changed, I thought it might be too much to ask a reviewer to re-review for non-functional changes such as these. But I will request Joel to do a quick re-review.
Thanks.
| |