Messages in this thread | | | Subject | Re: [PATCH 1/8] dt-bindings: sun6i-a31-mipi-dphy: Add the interrupts property | From | Samuel Holland <> | Date | Fri, 12 Aug 2022 17:44:50 -0500 |
| |
Hi Paul,
On 8/12/22 7:22 AM, Paul Kocialkowski wrote: > On Fri 12 Aug 22, 02:55, Samuel Holland wrote: >> The sun6i DPHY can generate several interrupts, mostly for reporting >> error conditions, but also for detecting BTA and UPLS sequences. >> Document this capability in order to accurately describe the hardware. >> >> The DPHY has no interrupt number provided in the vendor documentation >> because its interrupt line is shared with the DSI controller. > > Interesting! I do see DPHY_INT_EN*/PD* in the Allwinner BSP's > drivers/media/video/sunxi-vfe/mipi_csi/dphy/dphy_reg_i.h
You can also find some bit of documentation in the T7 User Manual.
> Maybe it would be useful to import the fields in the driver so that the > next person who'll try to debug DSI can use them directly? > > You might also want to submit a patch as [PATCH NOT FOR MERGE] that > adds an interrupt routine and some useful debugging.
I think this would be more interesting to someone who knew more about MIPI CSI/DSI and understood what those errors meant. :)
I'm mostly concerned with bringing up the D1 SoC at the moment.
> Do you think this is also available without a DSI controller? > I could just give it a try on V3/A83t here and find out :)
I would assume so. It could possibly be shared with the MIPI CSI interrupt (SPI 90) or keep its position at SPI 89.
Regards, Samuel
>> Fixes: c25b84c00826 ("dt-bindings: display: Convert Allwinner DSI to a schema") >> Signed-off-by: Samuel Holland <samuel@sholland.org> >> --- >> >> .../bindings/phy/allwinner,sun6i-a31-mipi-dphy.yaml | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/phy/allwinner,sun6i-a31-mipi-dphy.yaml b/Documentation/devicetree/bindings/phy/allwinner,sun6i-a31-mipi-dphy.yaml >> index 22636c9fdab8..cf49bd99b3e2 100644 >> --- a/Documentation/devicetree/bindings/phy/allwinner,sun6i-a31-mipi-dphy.yaml >> +++ b/Documentation/devicetree/bindings/phy/allwinner,sun6i-a31-mipi-dphy.yaml >> @@ -24,6 +24,9 @@ properties: >> reg: >> maxItems: 1 >> >> + interrupts: >> + maxItems: 1 >> + >> clocks: >> items: >> - description: Bus Clock >> @@ -53,6 +56,7 @@ required: >> - "#phy-cells" >> - compatible >> - reg >> + - interrupts >> - clocks >> - clock-names >> - resets >> -- >> 2.35.1 >> >
| |