Messages in this thread | | | Subject | Re: [PATCH 1/8] dt-bindings: sun6i-a31-mipi-dphy: Add the interrupts property | From | Samuel Holland <> | Date | Fri, 12 Aug 2022 17:19:09 -0500 |
| |
On 8/12/22 5:45 AM, Krzysztof Kozlowski wrote: > On 12/08/2022 10:55, Samuel Holland wrote: >> The sun6i DPHY can generate several interrupts, mostly for reporting >> error conditions, but also for detecting BTA and UPLS sequences. >> Document this capability in order to accurately describe the hardware. >> >> The DPHY has no interrupt number provided in the vendor documentation >> because its interrupt line is shared with the DSI controller. >> >> Fixes: c25b84c00826 ("dt-bindings: display: Convert Allwinner DSI to a schema") > > I don't understand what is being fixed in that commit. That commit did > not have interrupts in D-PHY, so what was broken by it? > > The Fixes tag annotates the commit which introduced a bug.
The binding had a bug because it did not accurately describe the hardware. If you don't think this warrants a Fixes tag, I can remove it. Or are you suggesting that the Fixes tag should instead reference the commit adding the original .txt binding?
Regards, Samuel
| |