lkml.org 
[lkml]   [2022]   [Aug]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
Subject[jpirko-mlxsw:jiri_devel_devlink_locking 33/40] drivers/net/ethernet/pensando/ionic/ionic_devlink.c:93:69: error: expected ')' before ';' token
tree:   https://github.com/jpirko/linux_mlxsw jiri_devel_devlink_locking
head: 3752df45a64c94afd110eeb956cd9adaeec586c1
commit: 95a8f1859e438effd49d5c1ae7828e87b8471180 [33/40] net: make drivers to use SET_NETDEV_DEVLINK_PORT to set devlink_port
config: x86_64-randconfig-a002 (https://download.01.org/0day-ci/archive/20220813/202208130548.6SBXNgLQ-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-3) 11.3.0
reproduce (this is a W=1 build):
# https://github.com/jpirko/linux_mlxsw/commit/95a8f1859e438effd49d5c1ae7828e87b8471180
git remote add jpirko-mlxsw https://github.com/jpirko/linux_mlxsw
git fetch --no-tags jpirko-mlxsw jiri_devel_devlink_locking
git checkout 95a8f1859e438effd49d5c1ae7828e87b8471180
# save the config file
mkdir build_dir && cp config build_dir/.config
make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/net/ethernet/pensando/ionic/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

In file included from drivers/net/ethernet/pensando/ionic/ionic_devlink.c:5:
drivers/net/ethernet/pensando/ionic/ionic_devlink.c: In function 'ionic_devlink_register':
include/linux/netdevice.h:2348:1: error: expected ';' before ')' token
2348 | )}
| ^
drivers/net/ethernet/pensando/ionic/ionic_devlink.c:93:9: note: in expansion of macro 'SET_NETDEV_DEVLINK_PORT'
93 | SET_NETDEV_DEVLINK_PORT(ionic->lif->netdev, &ionic->dl_port);
| ^~~~~~~~~~~~~~~~~~~~~~~
include/linux/netdevice.h:2348:1: error: expected statement before ')' token
2348 | )}
| ^
drivers/net/ethernet/pensando/ionic/ionic_devlink.c:93:9: note: in expansion of macro 'SET_NETDEV_DEVLINK_PORT'
93 | SET_NETDEV_DEVLINK_PORT(ionic->lif->netdev, &ionic->dl_port);
| ^~~~~~~~~~~~~~~~~~~~~~~
>> drivers/net/ethernet/pensando/ionic/ionic_devlink.c:93:69: error: expected ')' before ';' token
93 | SET_NETDEV_DEVLINK_PORT(ionic->lif->netdev, &ionic->dl_port);
| ^
>> drivers/net/ethernet/pensando/ionic/ionic_devlink.c:95:18: error: expected ';' before '}' token
95 | return 0;
| ^
| ;
96 | }
| ~
drivers/net/ethernet/pensando/ionic/ionic_devlink.c:96:1: error: control reaches end of non-void function [-Werror=return-type]
96 | }
| ^
cc1: some warnings being treated as errors


vim +93 drivers/net/ethernet/pensando/ionic/ionic_devlink.c

78
79 int ionic_devlink_register(struct ionic *ionic)
80 {
81 struct devlink *dl = priv_to_devlink(ionic);
82 struct devlink_port_attrs attrs = {};
83 int err;
84
85 attrs.flavour = DEVLINK_PORT_FLAVOUR_PHYSICAL;
86 devlink_port_attrs_set(&ionic->dl_port, &attrs);
87 err = devlink_port_register(dl, &ionic->dl_port, 0);
88 if (err) {
89 dev_err(ionic->dev, "devlink_port_register failed: %d\n", err);
90 return err;
91 }
92
> 93 SET_NETDEV_DEVLINK_PORT(ionic->lif->netdev, &ionic->dl_port);
94 devlink_register(dl);
> 95 return 0;
96 }
97

--
0-DAY CI Kernel Test Service
https://01.org/lkp

\
 
 \ /
  Last update: 2022-08-12 23:34    [W:0.052 / U:0.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site