Messages in this thread | | | Date | Fri, 12 Aug 2022 09:57:14 +0300 | Subject | Re: [PATCH 4/4] dt-bindings: net: dsa: mediatek,mt7530: update json-schema | From | Krzysztof Kozlowski <> |
| |
On 12/08/2022 01:09, Arınç ÜNAL wrote: >>> -patternProperties: >>> - "^(ethernet-)?ports$": >>> - type: object >> >> Actually four patches... >> >> I don't find this change explained in commit msg. What is more, it looks >> incorrect. All properties and patternProperties should be explained in >> top-level part. >> >> Defining such properties (with big piece of YAML) in each if:then: is no >> readable. > > I can't figure out another way. I need to require certain properties for > a compatible string AND certain enum/const for certain properties which > are inside patternProperties for "^(ethernet-)?port@[0-9]+$" by reading > the compatible string.
requiring properties is not equal to defining them and nothing stops you from defining all properties top-level and requiring them in allOf:if:then:patternProperties.
> If I put allOf:if:then under patternProperties, I can't do the latter.
You can.
> > Other than readability to human eyes, binding check works as intended, > in case there's no other way to do it.
I don't see the problem in doing it and readability is one of main factors of code admission to Linux kernel.
Best regards, Krzysztof
| |