Messages in this thread | | | From | SeongJae Park <> | Subject | Re: [PATCH] mm/damon/core: simplify the parameter passing for region split operation | Date | Fri, 12 Aug 2022 15:48:41 +0000 |
| |
Hi Kaixu,
On Fri, 12 Aug 2022 15:41:13 +0800 xiakaixu1987@gmail.com wrote:
> From: Kaixu Xia <kaixuxia@tencent.com> > > The parameter 'struct damon_target *t' is unnecessary in damon region > split operation, so we can remove it.
Good finding. But, 't' is used while 'ctx' is unused in 'damon_split_region_at()' and 'damon_split_regions_of'. Below code change is also removing 'ctx', not 't'. Could you please update the commit message for that?
Also, please fix the kernel test robot reported issues together: https://lore.kernel.org/damon/202208121823.8YTRPB1J-lkp@intel.com/
Thanks, SJ
[...]
| |