Messages in this thread | | | Date | Fri, 12 Aug 2022 14:41:09 +0200 | Subject | Re: [PATCH] ASoC: Intel: sof_rt5682: Add support for jsl_rt5682_rt1019 | From | Pierre-Louis Bossart <> |
| |
> static const struct snd_soc_acpi_codecs mx98360a_spk = { > .num_codecs = 1, > .codecs = {"MX98360A"} > @@ -78,6 +83,14 @@ struct snd_soc_acpi_mach snd_soc_acpi_intel_jsl_machines[] = { > .quirk_data = &mx98360a_spk, > .sof_tplg_filename = "sof-jsl-rt5682-mx98360a.tplg", > }, > + { > + .comp_ids = &rt5682_rt5682s_hp, > + .drv_name = "jsl_rt5682_rt1019", > + .sof_fw_filename = "sof-jsl.ri", > + .machine_quirk = snd_soc_acpi_codec_list, > + .quirk_data = &rt1019p_spk, > + .sof_tplg_filename = "sof-jsl-rt5682-rt1015.tplg",
this patch adds support for the rt1019, the line above looks like a copy-paste mistake.
We shouldn't use the same topology files for different platforms, it's not good maintenance-wise and since we store default values for some controls it's really not a good idea.
Please use a unique string such as sof-jsl-rt5682-rt1019.tplg, thanks.
> + }, > { > .id = "10134242", > .drv_name = "jsl_cs4242_mx98360a",
| |