lkml.org 
[lkml]   [2022]   [Aug]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 03/13] ASoC: amd: add acp6.2 init/de-init functions
On Fri, Aug 12, 2022 at 05:37:21PM +0530, Syed Saba kareem wrote:

> + /* power on */
> + ret = acp62_power_on(acp_base);
> + if (ret) {
> + pr_err("ACP power on failed\n");
> + return ret;
> + }

It would be better if you passed the device in so messages like this
could be dev_err() rather than just pr_err().
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2022-08-12 14:33    [W:0.841 / U:0.216 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site