lkml.org 
[lkml]   [2022]   [Aug]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 4/7] arm64: dts: imx93: add blk ctrl node
From
On 12/08/2022 10:46, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
>
> Add i.MX93 BLK CTRL MIX node
>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
> arch/arm64/boot/dts/freescale/imx93.dtsi | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx93.dtsi b/arch/arm64/boot/dts/freescale/imx93.dtsi
> index dd76472ced46..55f396723adb 100644
> --- a/arch/arm64/boot/dts/freescale/imx93.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx93.dtsi
> @@ -112,6 +112,11 @@ aips1: bus@44000000 {
> #size-cells = <1>;
> ranges;
>
> + anomix_ns_gpr: blk-ctrl-ns-anomix@44210000 {

Node names should be generic.
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation

> + compatible = "syscon";

No, syscon alone is not allowed.

> + reg = <0x44210000 0x1000>;
> + };
> +
> mu1: mailbox@44230000 {
> compatible = "fsl,imx93-mu", "fsl,imx8ulp-mu";
> reg = <0x44230000 0x10000>;
> @@ -174,6 +179,11 @@ aips2: bus@42000000 {
> #size-cells = <1>;
> ranges;
>
> + wakeupmix_gpr: blk-ctrl-wakeupmix@42420000 {
> + compatible = "syscon";

Ditto


Best regards,
Krzysztof

\
 
 \ /
  Last update: 2022-08-12 12:10    [W:0.232 / U:0.092 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site