Messages in this thread | | | Date | Thu, 11 Aug 2022 16:36:04 +0000 | From | William McVicker <> | Subject | Re: [PATCH v1 2/2] PCI: dwc: add support for 64-bit MSI target address |
| |
On 08/11/2022, Christoph Hellwig wrote: > On Tue, Aug 09, 2022 at 06:00:50PM +0000, Will McVicker wrote: > > + bool msi_64b = false; > > Spellt out bit here? > > > + msi_capabilities = dw_pcie_msi_capabilities(pci); > > + if (msi_capabilities & PCI_MSI_FLAGS_ENABLE) > > + msi_64b = msi_capabilities & PCI_MSI_FLAGS_64BIT ? true : false; > > No need for the tenary operator here: > > msi_64bit = msi_capabilities & PCI_MSI_FLAGS_64BIT;
Thanks for the suggestions. I'll update in the next patchset.
| |