lkml.org 
[lkml]   [2022]   [Aug]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH net 1/1] net: macsec: Fix XPN properties passing to macsec offload
    On Tue, 9 Aug 2022 13:29:05 +0300 Emeel Hakim wrote:
    > Currently macsec invokes HW offload path before reading extended
    > packet number (XPN) related user properties i.e. salt and short
    > secure channel identifier (ssci), hence preventing macsec XPN HW
    > offload.
    >
    > Fix by moving macsec XPN properties reading prior to HW offload path.
    >
    > Fixes: 48ef50fa866a ("macsec: Netlink support of XPN cipher suites")
    > Reviewed-by: Raed Salem <raeds@nvidia.com>
    > Signed-off-by: Emeel Hakim <ehakim@nvidia.com>

    Is there a driver in the tree which uses those values today?
    I can't grep out any rx_sa->key accesses in the drivers at all :S

    If there is none it's not really a fix.

    \
     
     \ /
      Last update: 2022-08-11 18:54    [W:3.959 / U:0.156 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site