lkml.org 
[lkml]   [2022]   [Aug]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.15 25/69] media: davinci: vpif: add missing of_node_put() in vpif_probe()
    Date
    From: Yang Yingliang <yangyingliang@huawei.com>

    [ Upstream commit bb45f5433f23cf103ba29c9692ee553e061f2cb4 ]

    of_graph_get_next_endpoint() returns an 'endpoint' node pointer
    with refcount incremented. The refcount should be decremented
    before returning from vpif_probe().

    Reported-by: Hulk Robot <hulkci@huawei.com>
    Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
    Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
    Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/media/platform/davinci/vpif.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/media/platform/davinci/vpif.c b/drivers/media/platform/davinci/vpif.c
    index 8ffc01c606d0..b4c78dce4d41 100644
    --- a/drivers/media/platform/davinci/vpif.c
    +++ b/drivers/media/platform/davinci/vpif.c
    @@ -469,6 +469,7 @@ static int vpif_probe(struct platform_device *pdev)
    endpoint);
    if (!endpoint)
    return 0;
    + of_node_put(endpoint);

    /*
    * For DT platforms, manually create platform_devices for
    --
    2.35.1
    \
     
     \ /
      Last update: 2022-08-11 18:21    [W:2.262 / U:2.180 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site