lkml.org 
[lkml]   [2022]   [Aug]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH v3 03/13] KVM: x86: emulator: introduce emulator_recalc_and_set_mode
    From

    On 8/3/2022 11:50 PM, Maxim Levitsky wrote:
    > [...]
    > +static inline int emulator_recalc_and_set_mode(struct x86_emulate_ctxt *ctxt)
    > +{
    > + u64 efer;
    > + struct desc_struct cs;
    > + u16 selector;
    > + u32 base3;
    > +
    > + ctxt->ops->get_msr(ctxt, MSR_EFER, &efer);
    > +
    > + if (!ctxt->ops->get_cr(ctxt, 0) & X86_CR0_PE) {
    Shouldn't this be:  !(ctxt->ops->get_cr(ctxt, 0) & X86_CR0_PE) ?
    > + /* Real mode. cpu must not have long mode active */
    > + if (efer & EFER_LMA)
    > + return X86EMUL_UNHANDLEABLE;
    > + ctxt->mode = X86EMUL_MODE_REAL;
    > + return X86EMUL_CONTINUE;
    > + }
    > +
    [...]
    > --
    > 2.26.3
    >

    \
     
     \ /
      Last update: 2022-08-11 17:43    [W:4.212 / U:0.780 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site