Messages in this thread | | | Date | Thu, 11 Aug 2022 23:33:51 +0800 | Subject | Re: [PATCH v3 03/13] KVM: x86: emulator: introduce emulator_recalc_and_set_mode | From | "Yang, Weijiang" <> |
| |
On 8/3/2022 11:50 PM, Maxim Levitsky wrote: > [...] > +static inline int emulator_recalc_and_set_mode(struct x86_emulate_ctxt *ctxt) > +{ > + u64 efer; > + struct desc_struct cs; > + u16 selector; > + u32 base3; > + > + ctxt->ops->get_msr(ctxt, MSR_EFER, &efer); > + > + if (!ctxt->ops->get_cr(ctxt, 0) & X86_CR0_PE) { Shouldn't this be: !(ctxt->ops->get_cr(ctxt, 0) & X86_CR0_PE) ? > + /* Real mode. cpu must not have long mode active */ > + if (efer & EFER_LMA) > + return X86EMUL_UNHANDLEABLE; > + ctxt->mode = X86EMUL_MODE_REAL; > + return X86EMUL_CONTINUE; > + } > + [...] > -- > 2.26.3 >
| |