lkml.org 
[lkml]   [2022]   [Aug]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.19 049/105] media: mediatek: vcodec: Report supported bitrate modes
    Date
    From: Hirokazu Honda <hiroh@chromium.org>

    [ Upstream commit d8e8aa866ed8636fd6c1017c3d9453eab2922496 ]

    The media driver supports constant bitrate mode only.
    The supported rate control mode is reported through querymenu() and
    s_ctrl() fails if non constant bitrate mode (e.g. VBR) is requested.

    Signed-off-by: Hirokazu Honda <hiroh@chromium.org>
    Reviewed-by: Irui Wang <irui.wang@mediatek.com>
    Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
    Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    .../media/platform/mediatek/vcodec/mtk_vcodec_enc.c | 11 +++++++++++
    1 file changed, 11 insertions(+)

    diff --git a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc.c b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc.c
    index c21367038c34..98d451ce2545 100644
    --- a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc.c
    +++ b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc.c
    @@ -50,6 +50,14 @@ static int vidioc_venc_s_ctrl(struct v4l2_ctrl *ctrl)
    int ret = 0;

    switch (ctrl->id) {
    + case V4L2_CID_MPEG_VIDEO_BITRATE_MODE:
    + mtk_v4l2_debug(2, "V4L2_CID_MPEG_VIDEO_BITRATE_MODE val= %d",
    + ctrl->val);
    + if (ctrl->val != V4L2_MPEG_VIDEO_BITRATE_MODE_CBR) {
    + mtk_v4l2_err("Unsupported bitrate mode =%d", ctrl->val);
    + ret = -EINVAL;
    + }
    + break;
    case V4L2_CID_MPEG_VIDEO_BITRATE:
    mtk_v4l2_debug(2, "V4L2_CID_MPEG_VIDEO_BITRATE val = %d",
    ctrl->val);
    @@ -1373,6 +1381,9 @@ int mtk_vcodec_enc_ctrls_setup(struct mtk_vcodec_ctx *ctx)
    0, V4L2_MPEG_VIDEO_H264_LEVEL_4_0);
    v4l2_ctrl_new_std_menu(handler, ops, V4L2_CID_MPEG_VIDEO_VP8_PROFILE,
    V4L2_MPEG_VIDEO_VP8_PROFILE_0, 0, V4L2_MPEG_VIDEO_VP8_PROFILE_0);
    + v4l2_ctrl_new_std_menu(handler, ops, V4L2_CID_MPEG_VIDEO_BITRATE_MODE,
    + V4L2_MPEG_VIDEO_BITRATE_MODE_CBR,
    + 0, V4L2_MPEG_VIDEO_BITRATE_MODE_CBR);


    if (handler->error) {
    --
    2.35.1
    \
     
     \ /
      Last update: 2022-08-11 17:39    [W:4.113 / U:0.136 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site