Messages in this thread | | | Date | Thu, 11 Aug 2022 12:14:43 +0200 | From | Markus Schneider-Pargmann <> | Subject | Re: [PATCH v2 1/4] dt-bindings: power: Add MT8365 power domains |
| |
Hi Angelo,
On Mon, Jul 25, 2022 at 10:54:58AM +0200, AngeloGioacchino Del Regno wrote: > Il 25/07/22 10:18, Markus Schneider-Pargmann ha scritto: > > From: Fabien Parent <fparent@baylibre.com> > > > > Add power domains dt-bindings for MT8365. > > > > Signed-off-by: Fabien Parent <fparent@baylibre.com> > > Signed-off-by: Markus Schneider-Pargmann <msp@baylibre.com> > > --- > > > > Notes: > > Changes in v2: > > - Made include/dt-bindings/power/mt8365-power.h dual-license. > > > > .../power/mediatek,power-controller.yaml | 2 ++ > > include/dt-bindings/power/mt8365-power.h | 19 +++++++++++++++++++ > > 2 files changed, 21 insertions(+) > > create mode 100644 include/dt-bindings/power/mt8365-power.h > > > > diff --git a/Documentation/devicetree/bindings/power/mediatek,power-controller.yaml b/Documentation/devicetree/bindings/power/mediatek,power-controller.yaml > > index 135c6f722091..2c6d3e4246b2 100644 > > --- a/Documentation/devicetree/bindings/power/mediatek,power-controller.yaml > > +++ b/Documentation/devicetree/bindings/power/mediatek,power-controller.yaml > > @@ -29,6 +29,7 @@ properties: > > - mediatek,mt8186-power-controller > > - mediatek,mt8192-power-controller > > - mediatek,mt8195-power-controller > > + - mediatek,mt8365-power-controller > > '#power-domain-cells': > > const: 1 > > @@ -67,6 +68,7 @@ patternProperties: > > "include/dt-bindings/power/mt8183-power.h" - for MT8183 type power domain. > > "include/dt-bindings/power/mt8192-power.h" - for MT8192 type power domain. > > "include/dt-bindings/power/mt8195-power.h" - for MT8195 type power domain. > > + "include/dt-bindings/power/mt8365-power.h" - for MT8365 type power domain. > > maxItems: 1 > > clocks: > > diff --git a/include/dt-bindings/power/mt8365-power.h b/include/dt-bindings/power/mt8365-power.h > > new file mode 100644 > > index 000000000000..e6cfd0ec7871 > > --- /dev/null > > +++ b/include/dt-bindings/power/mt8365-power.h > > Please rename this file to add the vendor prefix. > > mediatek,mt8365-power.h
Thank you for your feedback.
There are currently 12 'mt*-power.h' files without vendor prefix in that directory. I can change it, but it seems very inconsistent.
Best, Markus
| |