lkml.org 
[lkml]   [2022]   [Aug]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH v2 2/2] USB: trancevibrator: simplify tv_probe
Date
From: Dongliang Mu <mudongliangabcd@gmail.com>

The function tv_probe does not need to invoke kfree when the
allocation fails. So let's simplify the code of tv_probe.

Signed-off-by: Dongliang Mu <mudongliangabcd@gmail.com>
---
drivers/usb/misc/trancevibrator.c | 11 ++---------
1 file changed, 2 insertions(+), 9 deletions(-)

diff --git a/drivers/usb/misc/trancevibrator.c b/drivers/usb/misc/trancevibrator.c
index 55cb63652eda..30d4d774d448 100644
--- a/drivers/usb/misc/trancevibrator.c
+++ b/drivers/usb/misc/trancevibrator.c
@@ -84,22 +84,15 @@ static int tv_probe(struct usb_interface *interface,
{
struct usb_device *udev = interface_to_usbdev(interface);
struct trancevibrator *dev;
- int retval;

dev = kzalloc(sizeof(struct trancevibrator), GFP_KERNEL);
- if (!dev) {
- retval = -ENOMEM;
- goto error;
- }
+ if (!dev)
+ return -ENOMEM;

dev->udev = usb_get_dev(udev);
usb_set_intfdata(interface, dev);

return 0;
-
-error:
- kfree(dev);
- return retval;
}

static void tv_disconnect(struct usb_interface *interface)
--
2.35.1
\
 
 \ /
  Last update: 2022-08-11 11:05    [W:0.654 / U:0.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site