Messages in this thread | | | Date | Thu, 11 Aug 2022 11:58:10 +0300 | Subject | Re: [PATCH v2] pmic: add mt6366 regulator document | From | Krzysztof Kozlowski <> |
| |
On 11/08/2022 11:42, zhiyong.tao wrote: >> >>> >>> Signed-off-by: zhiyong tao <zhiyong.tao@mediatk.com> >>> --- >>> .../regulator/mediatek,mt6366-regulator.yaml | 375 >>> ++++++++++++++++++ >>> 1 file changed, 375 insertions(+) >> >> Subject does not match subsystem. > > Hi Krzysztof, > > Do you mean that we should change the title like this: > regulator: dt-bindings: mediatek: add mt6366 regulator document > is it right?
Yes. And remove redundant pieces so for example:
regulator: dt-bindings: mediatek: add mt6366 or: regulator: dt-bindings: add mediatek,mt6366
(...)
>>> + patternProperties: >>> + "^buck- >>> v(dram1|core|coresshub|proc11|proc12|gpu|s2|modem|s1)$": >>> + type: object >>> + $ref: "regulator.yaml#" >> >> No need for quotes. > ==> > We will remove the line "$ref: "regulator.yaml#"" in next verison, is > it right?
No, it is not. Why do you want to remove it?
Best regards, Krzysztof
| |