Messages in this thread | | | Date | Thu, 11 Aug 2022 04:53:08 -0400 | From | "Michael S. Tsirkin" <> | Subject | Re: [PATCH v5 3/4] drivers/net/virtio_net: Added RSS hash report. |
| |
On Mon, Mar 28, 2022 at 08:53:35PM +0300, Andrew Melnychenko wrote: > +static void virtio_skb_set_hash(const struct virtio_net_hdr_v1_hash *hdr_hash, > + struct sk_buff *skb) > +{ > + enum pkt_hash_types rss_hash_type; > + > + if (!hdr_hash || !skb) > + return; > + > + switch ((int)hdr_hash->hash_report) { > + case VIRTIO_NET_HASH_REPORT_TCPv4: > + case VIRTIO_NET_HASH_REPORT_UDPv4: > + case VIRTIO_NET_HASH_REPORT_TCPv6: > + case VIRTIO_NET_HASH_REPORT_UDPv6: > + case VIRTIO_NET_HASH_REPORT_TCPv6_EX: > + case VIRTIO_NET_HASH_REPORT_UDPv6_EX: > + rss_hash_type = PKT_HASH_TYPE_L4; > + break; > + case VIRTIO_NET_HASH_REPORT_IPv4: > + case VIRTIO_NET_HASH_REPORT_IPv6: > + case VIRTIO_NET_HASH_REPORT_IPv6_EX: > + rss_hash_type = PKT_HASH_TYPE_L3; > + break; > + case VIRTIO_NET_HASH_REPORT_NONE: > + default: > + rss_hash_type = PKT_HASH_TYPE_NONE; > + } > + skb_set_hash(skb, (unsigned int)hdr_hash->hash_value, rss_hash_type); > +} > + > static void receive_buf(struct virtnet_info *vi, struct receive_queue *rq, > void *buf, unsigned int len, void **ctx, > unsigned int *xdp_xmit,
I just noticed this- endian-ness broken here, you need _le16_to_cpu for hash_report and __le_32_to_cpu for hash_value.
-- MST
| |