Messages in this thread | | | From | Jay Vosburgh <> | Subject | Re: [PATCH] bonding: return -ENOMEM on rlb_initialize() allocation failure | Date | Thu, 11 Aug 2022 20:29:48 -0700 |
| |
Jiapeng Chong <jiapeng.chong@linux.alibaba.com> wrote:
>drivers/net/bonding/bond_alb.c:861 rlb_initialize() warn: returning -1 instead of -ENOMEM is sloppy.
I'll disagree; the return value is only ever tested for being non-zero.
-J
>Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=1896 >Reported-by: Abaci Robot <abaci@linux.alibaba.com> >Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> >--- > drivers/net/bonding/bond_alb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/drivers/net/bonding/bond_alb.c b/drivers/net/bonding/bond_alb.c >index 60cb9a0225aa..96cb4404b3c7 100644 >--- a/drivers/net/bonding/bond_alb.c >+++ b/drivers/net/bonding/bond_alb.c >@@ -858,7 +858,7 @@ static int rlb_initialize(struct bonding *bond) > > new_hashtbl = kmalloc(size, GFP_KERNEL); > if (!new_hashtbl) >- return -1; >+ return -ENOMEM; > > spin_lock_bh(&bond->mode_lock); > >-- >2.20.1.7.g153144c >
--- -Jay Vosburgh, jay.vosburgh@canonical.com
| |