Messages in this thread Patch in this message | | | From | Hangyu Hua <> | Subject | [PATCH] hid: hid-logitech-hidpp: avoid unnecessary assignments in hidpp_connect_event | Date | Fri, 12 Aug 2022 10:55:15 +0800 |
| |
hidpp->delayed_input can't be assigned to an object that already call input_free_device when input_register_device fails.
Fixes: c39e3d5fc9dd ("HID: logitech-hidpp: late bind the input device on wireless connection") Signed-off-by: Hangyu Hua <hbh25y@gmail.com> --- drivers/hid/hid-logitech-hidpp.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid-logitech-hidpp.c index 68f9e9d207f4..c3602bf8f9b9 100644 --- a/drivers/hid/hid-logitech-hidpp.c +++ b/drivers/hid/hid-logitech-hidpp.c @@ -3959,8 +3959,10 @@ static void hidpp_connect_event(struct hidpp_device *hidpp) hidpp_populate_input(hidpp, input); ret = input_register_device(input); - if (ret) + if (ret) { input_free_device(input); + return; + } hidpp->delayed_input = input; } -- 2.25.1
| |