Messages in this thread | | | Date | Thu, 11 Aug 2022 15:50:00 -0600 | From | "Daniel Xu" <> | Subject | Re: [PATCH bpf-next v3 0/3] Add more bpf_*_ct_lookup() selftests |
| |
Hi Kumar,
On Wed, Aug 10, 2022, at 6:25 PM, Kumar Kartikeya Dwivedi wrote: > On Thu, 11 Aug 2022 at 01:16, Daniel Xu <dxu@dxuuu.xyz> wrote: >> >> This patchset adds more bpf_*_ct_lookup() selftests. The goal is to test >> interaction with netfilter subsystem as well as reading from `struct >> nf_conn`. The first is important when migrating legacy systems towards >> bpf. The latter is important in general to take full advantage of >> connection tracking. >> > > Thank you for contributing these tests. Feel free to add: > Acked-by: Kumar Kartikeya Dwivedi <memxor@gmail.com> > > People often look at selftests for usage examples these days, so it's > great to have coverage + examples for more use cases.
I also want this interaction to still work when I start using it later :).
> >> I'll follow this patchset up with support for writing to `struct nf_conn`. >> > > Please also cc netfilter-devel, netdev, Pablo, and Florian when you send it. >
Ack.
> I think we can directly enable stores to ct->mark, since that is what > ctnetlink is doing too, so adding another helper for this would be > unnecessary overhead.
Ack.
[...]
Thanks, Danel
| |