Messages in this thread | | | Date | Thu, 11 Aug 2022 22:28:27 +0100 | From | Matthew Wilcox <> | Subject | Re: [PATCH] sched/all: Change BUG_ON() instances to WARN_ON() |
| |
On Thu, Aug 11, 2022 at 01:43:09PM -0700, Linus Torvalds wrote: > May I suggest going one step further, and making these WARN_ON_ONCE() instead. > > >From personal experience, once some scheduler bug (or task struct > corruption) happens, ti often *keeps* happening, and the logs just > fill up with more and more data, to the point where you lose sight of > the original report (and the machine can even get unusable just from > the logging).
I've been thinking about magically turning all the WARN_ON_ONCE() into (effectively) WARN_ON_RATELIMIT(). I had some patches in that direction a while ago but never got round to tidying them up for submission.
| |