lkml.org 
[lkml]   [2022]   [Aug]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 1/4] dt-bindings: PCI: fu740-pci: fix missing clock-names
    Date
    From: Conor Dooley <conor.dooley@microchip.com>

    The commit in the fixes tag removed the clock-names property from the
    SiFive FU740 PCI Controller dt-binding, but it was already in the dts
    for the FU740. dtbs_check was not able to pick up on this at the time
    but v2022.08 of dt-schema now can:

    arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dtb: pcie@e00000000: Unevaluated properties are not allowed ('clock-names' was unexpected)
    From schema: linux/Documentation/devicetree/bindings/pci/sifive,fu740-pcie.yaml

    The Linux driver does not use this property, but outside of the kernel
    this property may have users. Re-add the property and its "clocks"
    dependency.

    Fixes: b92225b034c0 ("dt-bindings: PCI: designware: Fix 'unevaluatedProperties' warnings")
    Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
    ---
    I went back and forth on removing the property from the dts, but this
    seems like the change that is more conservative..
    ---
    .../devicetree/bindings/pci/sifive,fu740-pcie.yaml | 6 ++++++
    1 file changed, 6 insertions(+)

    diff --git a/Documentation/devicetree/bindings/pci/sifive,fu740-pcie.yaml b/Documentation/devicetree/bindings/pci/sifive,fu740-pcie.yaml
    index 195e6afeb169..c7a9a2dc0fa6 100644
    --- a/Documentation/devicetree/bindings/pci/sifive,fu740-pcie.yaml
    +++ b/Documentation/devicetree/bindings/pci/sifive,fu740-pcie.yaml
    @@ -51,6 +51,12 @@ properties:
    description: A phandle to the PCIe power up reset line.
    maxItems: 1

    + clocks:
    + maxItems: 1
    +
    + clock-names:
    + const: pcie_aux
    +
    pwren-gpios:
    description: Should specify the GPIO for controlling the PCI bus device power on.
    maxItems: 1
    --
    2.37.1
    \
     
     \ /
      Last update: 2022-08-11 22:34    [W:2.760 / U:0.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site