Messages in this thread | | | Date | Wed, 10 Aug 2022 18:20:24 +0200 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH v5 4/5] Bluetooth: btusb: Add btusb devcoredump support |
| |
On Wed, Aug 10, 2022 at 09:00:37AM -0700, Manish Mandlik wrote: > This patch implements the btusb driver side .coredump() callback to > trigger a devcoredump via sysfs and .enable_coredump() callback to > check if the devcoredump functionality is enabled for a device. > > Signed-off-by: Manish Mandlik <mmandlik@google.com> > Reviewed-by: Abhishek Pandit-Subedi <abhishekpandit@chromium.org> > --- > > (no changes since v4) > > Changes in v4: > - New patch in the series > > drivers/bluetooth/btusb.c | 31 +++++++++++++++++++++++++++++++ > 1 file changed, 31 insertions(+) > > diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c > index 30dd443f395f..b00851327aa3 100644 > --- a/drivers/bluetooth/btusb.c > +++ b/drivers/bluetooth/btusb.c > @@ -1510,6 +1510,15 @@ static void btusb_isoc_tx_complete(struct urb *urb) > kfree_skb(skb); > } > > +#ifdef CONFIG_DEV_COREDUMP > +static bool btusb_coredump_enabled(struct hci_dev *hdev) > +{ > + struct btusb_data *data = hci_get_drvdata(hdev); > + > + return !data->intf->dev.coredump_disabled; > +} > +#endif
Again, #ifdef in .c files is unmaintainable over time, please do not do it if at all possible.
thanks,
greg k-h
| |