lkml.org 
[lkml]   [2022]   [Aug]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v2 1/2] spi: stm32_qspi: Add transfer_one_message() spi callback
From
Hi Mark

On 8/10/22 15:06, Mark Brown wrote:
> On Wed, Aug 10, 2022 at 11:32:14AM +0200, patrice.chotard@foss.st.com wrote:
>
>> Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>
>>
>> v2: _ use parallel-memories property
>> _ set auto_runtime_pm to true
>> _ remove pm_runtime_*() usage in transfer_one_message() callback
>> ---
>
> The changelog should come after the --- so that it gets automatically
> stripped out by tooling. No need to resend just for this.
>
>> + /*
>> + * Dual flash mode is only enable in case "parallel-memories" and
>> + * "cs-gpios" properties are found in DT
>> + */
>> + if (of_property_read_bool(dev->of_node, "parallel-memories") &&
>> + of_gpio_named_count(dev->of_node, "cs-gpios")) {
>> + qspi->cr_reg = CR_DFM;
>> + dev_dbg(dev, "Dual flash mode enable");
>> + }
>
> Do we need to add something to the DT bindings to indicate that
> parallel-memories is valid?

You mean in the st,stm32-qspi.yaml DT binding file ? Right i think it could be preferable to add it.


Patrice

\
 
 \ /
  Last update: 2022-08-10 15:16    [W:0.080 / U:0.064 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site