lkml.org 
[lkml]   [2022]   [Aug]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v1 1/2] serial: pic32_uart: Utilize uart_console_enabled()
On Sun, 7 Aug 2022, Andy Shevchenko wrote:

> The serial core already provides a helper to check if the given port
> is an enabled console. Utilize it instead of open coded variant.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>

--
i.

> ---
> drivers/tty/serial/pic32_uart.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/pic32_uart.c b/drivers/tty/serial/pic32_uart.c
> index f418f1de66b3..1562c2a48467 100644
> --- a/drivers/tty/serial/pic32_uart.c
> +++ b/drivers/tty/serial/pic32_uart.c
> @@ -943,7 +943,7 @@ static int pic32_uart_probe(struct platform_device *pdev)
> }
>
> #ifdef CONFIG_SERIAL_PIC32_CONSOLE
> - if (uart_console(port) && (pic32_console.flags & CON_ENABLED)) {
> + if (uart_console_enabled(port)) {
> /* The peripheral clock has been enabled by console_setup,
> * so disable it till the port is used.
> */
>
\
 
 \ /
  Last update: 2022-08-10 10:26    [W:0.057 / U:0.436 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site