Messages in this thread |  | | Date | Mon, 1 Aug 2022 11:10:25 -0700 | From | Andres Freund <> | Subject | Re: [PATCH v3 3/8] tools include: add dis-asm-compat.h to handle version differences |
| |
Hi,
On 2022-08-01 15:05:00 -0300, Arnaldo Carvalho de Melo wrote: > Em Sun, Jul 31, 2022 at 06:38:29PM -0700, Andres Freund escreveu: > > binutils changed the signature of init_disassemble_info(), which now causes > > compilation failures for tools/{perf,bpf}, e.g. on debian unstable. > > Relevant binutils commit: > > https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=60a3da00bd5407f07 > > > > This commit introduces a wrapper for init_disassemble_info(), to avoid > > spreading #ifdef DISASM_INIT_STYLED to a bunch of places. Subsequent > > commits will use it to fix the build failures. > > > > It likely is worth adding a wrapper for disassember(), to avoid the already > > existing DISASM_FOUR_ARGS_SIGNATURE ifdefery. > > > > Cc: Alexei Starovoitov <ast@kernel.org> > > Cc: Arnaldo Carvalho de Melo <acme@redhat.com> > > Cc: Sedat Dilek <sedat.dilek@gmail.com> > > Cc: Quentin Monnet <quentin@isovalent.com> > > Cc: Ben Hutchings <benh@debian.org> > > Link: http://lore.kernel.org/lkml/20220622181918.ykrs5rsnmx3og4sv@alap3.anarazel.de > > Signed-off-by: Andres Freund <andres@anarazel.de> > > Signed-off-by: Ben Hutchings <benh@debian.org> > > So, who is the author of this patch? Ben? b4 complained about it:
I squashed a fixup of Ben into my patch (moving the include in annotate.c into the HAVE_LIBBFD_SUPPORT section). I don't know what the proper procedure is for that - I'd asked in https://lore.kernel.org/20220715191641.go6xbmhic3kafcsc@awork3.anarazel.de
> NOTE: some trailers ignored due to from/email mismatches: > ! Trailer: Signed-off-by: Ben Hutchings <benh@debian.org> > Msg From: Andres Freund <andres@anarazel.de> > NOTE: Rerun with -S to apply them anyway > > If it is Ben, then we would need a: > > From: Ben Hutchings <benh@debian.org> > > At the beginning of the patch, right?
I don't know, I interact with the kernel processes too rarely...
Greetings,
Andres Freund
|  |