Messages in this thread | | | Date | Mon, 1 Aug 2022 14:56:20 -0300 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH] perf symbol: Fail to read phdr workaround |
| |
Em Mon, Aug 01, 2022 at 09:25:11PM +0800, Leo Yan escreveu: > On Mon, Aug 01, 2022 at 09:38:23AM -0300, Arnaldo Carvalho de Melo wrote: > > Em Sun, Jul 31, 2022 at 11:19:15PM -0700, Ian Rogers escreveu: > > > On Sun, Jul 31, 2022, 6:53 PM Leo Yan <leo.yan@linaro.org> wrote: > > > > > > > On Sun, Jul 31, 2022 at 09:49:23AM -0700, Ian Rogers wrote: > > > > > The perf jvmti agent doesn't create program headers, in this case > > > > > fallback on section headers as happened previously. > > > > > > > > > > Fixes: 882528d2e776 ("perf symbol: Skip symbols if SHF_ALLOC flag is not > > > > set") > > > > > > > > It's good to change fix tag as: > > > > Fixes: 2d86612aacb7 ("perf symbol: Correct address for bss symbols") > > > > > > > > > > Doh! I was rushing this morning. Thanks for catching and reviewing! > > > > I made the adjustments and added a note with the repro, to help in the > > future when trying to test this area. > > Thanks, Arnaldo. > > > I also think we could have something like a 'perf test' mode where, when > > asked to, it would enable tests that involve downloading such files to > > perform tests, such as this dacapo benchmark, and then would test if the > > output matches expectations. > > I will add a testing based on the steps, alongside with the discussed > testing for data symbols. Will share out after get ready.
Great! Thanks in advance,
- Arnaldo
| |