Messages in this thread | | | Date | Mon, 1 Aug 2022 19:54:54 +0200 | Subject | Re: [RFC PATCH net-next] dt-bindings: net: dsa: mediatek,mt7530: completely rework binding | From | Krzysztof Kozlowski <> |
| |
On 30/07/2022 10:24, Arınç ÜNAL wrote: > Hi Krzysztof, > > On 27.07.2022 13:29, Krzysztof Kozlowski wrote: >> On 26/07/2022 14:24, Arınç ÜNAL wrote: >>> Completely rework the binding for MediaTek MT7530 and MT7531 switches. >> >> Rules are the same for schema as for driver - one patch, one thing. You >> mix here trivial style changes (removal of quotes) with functional stuff. >> >> Patch is unreviewable, so it must be split. > > Thank you. I'm going to split it this way: > - Trivial changes; fix title and property descriptions, remove quotes, > add me as maintainer, etc. > - Update binding description > - Update json-schema for compatible devices > - Update examples > > Let me know if you have any objections.
Depends what are these "udpates". One logical change = one patch. Adding compatible in one patch and then adding example for it, is not correct.
Best regards, Krzysztof
| |