Messages in this thread Patch in this message | | | Date | Mon, 1 Aug 2022 10:54:01 -0700 | Subject | [PATCH bpf-next v6 2/8] cgroup: enable cgroup_get_from_file() on cgroup1 | From | Hao Luo <> |
| |
From: Yosry Ahmed <yosryahmed@google.com>
From: Yosry Ahmed <yosryahmed@google.com>
cgroup_get_from_file() currently fails with -EBADF if called on cgroup v1. However, the current implementation works on cgroup v1 as well, so the restriction is unnecessary.
This enabled cgroup_get_from_fd() to work on cgroup v1, which would be the only thing stopping bpf cgroup_iter from supporting cgroup v1.
Signed-off-by: Yosry Ahmed <yosryahmed@google.com> Acked-by: Tejun Heo <tj@kernel.org> Signed-off-by: Hao Luo <haoluo@google.com> --- kernel/cgroup/cgroup.c | 5 ----- 1 file changed, 5 deletions(-)
diff --git a/kernel/cgroup/cgroup.c b/kernel/cgroup/cgroup.c index 13c8e91d7862..49803849a289 100644 --- a/kernel/cgroup/cgroup.c +++ b/kernel/cgroup/cgroup.c @@ -6099,11 +6099,6 @@ static struct cgroup *cgroup_get_from_file(struct file *f) return ERR_CAST(css); cgrp = css->cgroup; - if (!cgroup_on_dfl(cgrp)) { - cgroup_put(cgrp); - return ERR_PTR(-EBADF); - } - return cgrp; } -- 2.37.1.455.g008518b4e5-goog
| |