lkml.org 
[lkml]   [2022]   [Aug]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] scsi: FlashPoint: remove redundant variable bm_int_st
From
On 7/30/22 06:37, Colin Ian King wrote:
> The variable bm_int_st is assigned a value but it is never read. The
> variable and the assignment are redundant and can be removed.
>
> Cleans up clang scan build warning:
> drivers/scsi/FlashPoint.c:1726:7: warning: Although the value stored
> to 'bm_int_st' is used in the enclosing expression, the value is never
> actually read from 'bm_int_st' [deadcode.DeadStores]
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> ---
> drivers/scsi/FlashPoint.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)

Acked-by: Khalid Aziz <khalid@gonehiking.org>


>
> diff --git a/drivers/scsi/FlashPoint.c b/drivers/scsi/FlashPoint.c
> index 90253208a72f..3d9c56ac8224 100644
> --- a/drivers/scsi/FlashPoint.c
> +++ b/drivers/scsi/FlashPoint.c
> @@ -1712,7 +1712,7 @@ static unsigned char FlashPoint_InterruptPending(void *pCurrCard)
> static int FlashPoint_HandleInterrupt(void *pcard)
> {
> struct sccb *currSCCB;
> - unsigned char thisCard, result, bm_status, bm_int_st;
> + unsigned char thisCard, result, bm_status;
> unsigned short hp_int;
> unsigned char i, target;
> struct sccb_card *pCurrCard = pcard;
> @@ -1723,7 +1723,7 @@ static int FlashPoint_HandleInterrupt(void *pcard)
>
> MDISABLE_INT(ioport);
>
> - if ((bm_int_st = RD_HARPOON(ioport + hp_int_status)) & EXT_STATUS_ON)
> + if (RD_HARPOON(ioport + hp_int_status) & EXT_STATUS_ON)
> bm_status = RD_HARPOON(ioport + hp_ext_status) &
> (unsigned char)BAD_EXT_STATUS;
> else

\
 
 \ /
  Last update: 2022-08-01 18:35    [W:0.046 / U:0.124 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site