Messages in this thread | | | Date | Mon, 1 Aug 2022 10:13:47 -0600 | From | Rob Herring <> | Subject | Re: [PATCH -next] of/fdt: declared return type does not match actual return type |
| |
On Mon, 01 Aug 2022 12:05:06 +0000, Xu Qiang wrote: > The commit 649cab56de8e (“of: properly check for error returned > by fdt_get_name()”) changed the return value type from bool to int, > but forgot to change the return value simultaneously. > > populate_node was only called in unflatten_dt_nodes, and returns > with values greater than or equal to 0 were discarded without further > processing. Considering that return 0 usually indicates success, > return 0 instead of return true. > > Fixes: 649cab56de8e (“of: properly check for error returned by fdt_get_name()”) > Signed-off-by: Xu Qiang <xuqiang36@huawei.com> > --- > drivers/of/fdt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >
Applied, thanks!
| |