lkml.org 
[lkml]   [2022]   [Aug]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] regulator: sun20i: Add support for Allwinner D1 LDOs
On Sun, Jul 31, 2022 at 11:47:58PM -0500, Samuel Holland wrote:

> +static const struct regulator_desc sun20i_d1_analog_ldo_descs[] = {
> + {
> + .name = "aldo",
> + .supply_name = "vdd33",
> + .of_match = "aldo",
> + .ops = &sun20i_d1_analog_ldo_ops,
> + .type = REGULATOR_VOLTAGE,
> + .owner = THIS_MODULE,
> + .n_voltages = BIT(3),

I'm really unconvinced that using BIT() is clearer than just writing the
number of voltages directly as a number.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2022-08-01 18:04    [W:0.537 / U:0.248 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site