Messages in this thread | | | Date | Mon, 1 Aug 2022 17:03:33 +0100 | From | Mark Brown <> | Subject | Re: [PATCH 2/2] regulator: sun20i: Add support for Allwinner D1 LDOs |
| |
On Sun, Jul 31, 2022 at 11:47:58PM -0500, Samuel Holland wrote:
> +static const struct regulator_desc sun20i_d1_analog_ldo_descs[] = { > + { > + .name = "aldo", > + .supply_name = "vdd33", > + .of_match = "aldo", > + .ops = &sun20i_d1_analog_ldo_ops, > + .type = REGULATOR_VOLTAGE, > + .owner = THIS_MODULE, > + .n_voltages = BIT(3),
I'm really unconvinced that using BIT() is clearer than just writing the number of voltages directly as a number. [unhandled content-type:application/pgp-signature] | |