lkml.org 
[lkml]   [2022]   [Aug]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 1/4] ARM: dts: bcmbca: fix arch timer node cpu mask flag value
From
Hi William,

On 7/28/2022 6:50 PM, William Zhang wrote:
> The cpu mask flag value should match the number of cpu cores in the
> chip. Correct the value accordingly for BCM63178, BCM6846 and BCM6878.
>
> Fixes: fc85b7e64acb ("ARM: dts: add dts files for bcmbca soc 63178")
> Fixes: de1a99ac0b64 ("ARM: dts: Add DTS files for bcmbca SoC BCM6846")
> Fixes: 6bcad714e173 ("ARM: dts: Add DTS files for bcmbca SoC BCM6878")
>
> Signed-off-by: William Zhang <william.zhang@broadcom.com>

This looks fine, if you could split one patch per file you modify that
would look a bit better, this is particularly relevant for bug fixes so
if you can split patch 1 into 3, patch 2 into 2 and patch 3 into 2 that
would be great. Patch 4 can be taken as is since it is sort of a
bca-wide cleanup.

Right now all of those changes went into the same release cycle, but in
the future that might not be the case.

Thank you!
--
Florian

\
 
 \ /
  Last update: 2022-08-01 17:33    [W:0.036 / U:0.360 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site