Messages in this thread | | | Date | Mon, 1 Aug 2022 16:40:50 +0200 | From | Jiri Pirko <> | Subject | Re: [PATCH] net: devlink: Fix missing mutex_unlock() call |
| |
Mon, Aug 01, 2022 at 01:59:56PM CEST, ammarfaizi2@gnuweeb.org wrote: >From: Ammar Faizi <ammarfaizi2@gnuweeb.org> > >Commit 2dec18ad826f forgets to call mutex_unlock() before the function >returns in the error path: > > New smatch warnings: > net/core/devlink.c:6392 devlink_nl_cmd_region_new() warn: inconsistent \ > returns '®ion->snapshot_lock'. > >Make sure we call mutex_unlock() in this error path. > >Reported-by: kernel test robot <lkp@intel.com> >Reported-by: Dan Carpenter <dan.carpenter@oracle.com> >Fixes: 2dec18ad826f52658f7781ee995d236cc449b678 ("net: devlink: remove region snapshots list dependency on devlink->lock") >Signed-off-by: Ammar Faizi <ammarfaizi2@gnuweeb.org>
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
Thanks for the fix!
| |